Skip to content

Backport CS* tightening#1889

Merged
flying-sheep merged 8 commits into
0.11.xfrom
pa/cs-types
Mar 6, 2025
Merged

Backport CS* tightening#1889
flying-sheep merged 8 commits into
0.11.xfrom
pa/cs-types

Conversation

@flying-sheep
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep commented Mar 6, 2025 •
edited
Loading

So the accurate types are used in a soon-to-be-released anndata version.

I also did a few things I missed in the original review. Getting these into main in a separate PR: #1890

TODO:

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (f996bb1) to head (5863c6d).
Report is 28 commits behind head on 0.11.x.

Files with missing lines Patch % Lines
src/anndata/_core/merge.py 83.33% 1 Missing ⚠️
src/anndata/compat/__init__.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           0.11.x    #1889      +/-   ##
==========================================
- Coverage   86.20%   83.75%   -2.46%     
==========================================
  Files          41       41              
  Lines        6250     6255       +5     
==========================================
- Hits         5388     5239     -149     
- Misses        862     1016     +154
Files with missing lines Coverage Δ
src/anndata/_core/aligned_mapping.py 93.41% <100.00%> (-0.03%) ⬇️
src/anndata/_core/anndata.py 82.47% <100.00%> (ø)
src/anndata/_core/index.py 93.60% <100.00%> (ø)
src/anndata/_core/raw.py 75.88% <100.00%> (-4.26%) ⬇️
src/anndata/_core/sparse_dataset.py 92.14% <100.00%> (ø)
src/anndata/_io/h5ad.py 92.68% <ø> (ø)
src/anndata/_io/specs/lazy_methods.py 97.80% <ø> (ø)
src/anndata/_io/specs/methods.py 88.10% <100.00%> (-0.42%) ⬇️
src/anndata/abc.py 100.00% <100.00%> (ø)
src/anndata/typing.py 100.00% <ø> (ø)
... and 2 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flying-sheep flying-sheep marked this pull request as ready for review March 6, 2025 09:58
@flying-sheep flying-sheep requested a review from ilan-gold March 6, 2025 09:59
@flying-sheep flying-sheep mentioned this pull request Mar 6, 2025
Merged
3 tasks
@flying-sheep flying-sheep added this to the 0.11.4 milestone Mar 6, 2025
@flying-sheep flying-sheep self-assigned this Mar 6, 2025
ilan-gold
ilan-gold approved these changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the failing CI, looks good

@flying-sheep flying-sheep enabled auto-merge (squash) March 6, 2025 15:02
@flying-sheep flying-sheep merged commit 49b4bb4 into 0.11.x Mar 6, 2025
@flying-sheep flying-sheep deleted the pa/cs-types branch March 6, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilan-gold ilan-gold ilan-gold approved these changes

Assignees

@flying-sheep flying-sheep

Labels

skip-gpu-ci

Projects

None yet

Milestone

0.11.4

Development

Successfully merging this pull request may close these issues.

2 participants

@flying-sheep @ilan-gold